Skip to content

🐛 Fixed issues with cancellation #8521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 15, 2025
Merged

🐛 Fixed issues with cancellation #8521

merged 7 commits into from
Oct 15, 2025

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 15, 2025 •
edited
Loading

What do these changes do?

Fixed issues:

  • servicelib: deferred_tasks were not being cancelled, they were timing out, fixed the issue
  • dynamic_scheduler: operations with repeatable steps could not be cancelled during the period in which they were waiting before repeating the steps
  • dynamic_scheduler: flaky test was not raising CannotCancelWhileWaitingForManualInterventionError

Related issue/s

How to test

Dev-ops

@codecov
Copy link

codecov bot commented Oct 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.38%. Comparing base (ae65afb) to head (690c02a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8521      +/-   ##
==========================================
- Coverage   89.14%   87.38%   -1.76%     
==========================================
  Files        1795     1572     -223     
  Lines       70487    65350    -5137     
  Branches      836      682     -154     
==========================================
- Hits        62834    57107    -5727     
- Misses       7433     8003     +570     
- Partials      220      240      +20
Flag Coverage Δ
integrationtests 64.00% <ø> (-9.30%) ⬇️
unittests 85.84% <75.00%> (-2.11%) ⬇️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 70.96% <40.00%> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.95% <ø> (ø)
agent 93.10% <ø> (ø)
api_server 91.86% <ø> (ø)
autoscaling 95.73% <ø> (ø)
catalog 92.06% <ø> (ø)
clusters_keeper 99.14% <ø> (ø)
dask_sidecar 92.38% <ø> (ø)
datcore_adapter 97.95% <ø> (ø)
director 75.72% <ø> (ø)
director_v2 90.90% <ø> (+0.01%) ⬆️
dynamic_scheduler 96.82% <100.00%> (+<0.01%) ⬆️
dynamic_sidecar 90.44% <ø> (ø)
efs_guardian 89.83% <ø> (ø)
invitations 90.90% <ø> (ø)
payments 92.80% <ø> (ø)
resource_usage_tracker 92.22% <ø> (ø)
storage 86.86% <ø> (+0.36%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.09% <ø> (+0.70%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae65afb...690c02a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 690c02a.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@GitHK GitHK added this to the Imparable milestone Oct 15, 2025
@GitHK GitHK self-assigned this Oct 15, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GitHK GitHK changed the title 🐛 Fixed cancelling operations 🐛 Fixed issues with cancellation Oct 15, 2025
@GitHK GitHK marked this pull request as ready for review October 15, 2025 11:04
@GitHK GitHK requested a review from pcrespov as a code owner October 15, 2025 11:04
@GitHK GitHK enabled auto-merge (squash) October 15, 2025 11:05
@GitHK GitHK disabled auto-merge October 15, 2025 11:05
@GitHK GitHK added a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work a:dynamic-scheduler labels Oct 15, 2025
pcrespov
pcrespov approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@GitHK GitHK merged commit 7911738 into ITISFoundation:master Oct 15, 2025
93 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-migrate-dy-scheduler-part10 branch October 15, 2025 11:36
This was referenced Oct 28, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@GitHK GitHK

Labels

a:dynamic-scheduler a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work

Projects

None yet

Milestone

Imparable

Development

Successfully merging this pull request may close these issues.

3 participants

@GitHK @giancarloromeo @pcrespov